Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ConstZero instead of Default #838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use ConstZero instead of Default #838

wants to merge 1 commit into from

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented May 9, 2024 •
edited
Loading

Advantages:

  • more consts
  • zero is more semantically correct then default
  • cleaner code

Disadvantages:

  • advanced num-traits dependency
  • rustdoc still not good with const defaults. Prints
    изображение

instead of const ZERO_TO_MODIFY_FIELDS_BITMAP: u32 = 0 for default value.

cc @Emilgardis

@burrbull burrbull requested a review from a team as a code owner May 9, 2024 04:37
@burrbull burrbull force-pushed the const-default branch 2 times, most recently from 96ad0c3 to f6246e3 Compare May 9, 2024 04:43
@burrbull

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@burrbull burrbull changed the title use ConstDefault instead of Default use ConstZero instead of Default Dec 11, 2024
@burrbull burrbull force-pushed the const-default branch 5 times, most recently from d22e32e to 379a857 Compare December 14, 2024 17:31
@burrbull
Copy link
Member Author

/ci diff pr

@github-actions GitHub Actions
Copy link

Diff for comment

@burrbull
Copy link
Member Author

@Emilgardis @adamgreig what do you think about this change?

@Emilgardis
Copy link
Member

Not sure i understand why num-traits is needed for this, could you elaborate?

@burrbull
Copy link
Member Author

burrbull commented Feb 13, 2025 •
edited
Loading

Not sure i understand why num-traits is needed for this, could you elaborate?

We can introduce our own Zero trait if you are saying about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burrbull @Emilgardis